Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing kwargs in Lorentz.from_nk #2067

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

momchil-flex
Copy link
Collaborator

One last small thing noticed by MC...

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, maybe add kwargs to the docstring as well?

@momchil-flex
Copy link
Collaborator Author

Done, they were not present in the docstring of any of the methods... (this may be an omission we have in various other places)

@tylerflex
Copy link
Collaborator

I might be wrong but now it looks like the kwarg passing part of the code is no longer present?

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong. feel free to merge

@momchil-flex momchil-flex merged commit e8867ca into develop Nov 13, 2024
15 checks passed
@momchil-flex momchil-flex deleted the momchil/lorentz_from_nk branch November 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants