Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential self-intersection polygon in Scene._filter_structures_plane #2072

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix potential self-intersection polygon in Scene._filter_structures_plane #2072

wants to merge 1 commit into from

Conversation

weiliangjin2021
Copy link
Collaborator

@weiliangjin2021 weiliangjin2021 commented Nov 14, 2024 •
edited
Loading

This fixes the shapely/GEOS error in mode solver metadata pipeline when trying to find materials on the modal plane.

Hard to fabricate a test myself so I'll leave it out.

@weiliangjin2021 weiliangjin2021 added the Bug something isnt working label Nov 14, 2024
@weiliangjin2021 weiliangjin2021 changed the base branch from pre/2.8 to develop November 14, 2024 19:49
lucas-flexcompute
lucas-flexcompute approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@lucas-flexcompute lucas-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens all the time with shapely… I'm guessing .buffer(0) is better than make_valid(...) in this case, is that so?

@weiliangjin2021
Copy link
Collaborator Author

Happens all the time with shapely… I'm guessing .buffer(0) is better than make_valid(...) in this case, is that so?

make_valid does nothing in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-flexcompute lucas-flexcompute lucas-flexcompute approved these changes

@momchil-flex momchil-flex Awaiting requested review from momchil-flex

Assignees
No one assigned
Labels
Bug something isnt working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiliangjin2021 @lucas-flexcompute