Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unit test gen #62

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fixed unit test gen #62

merged 3 commits into from
Jan 16, 2025

Conversation

VladIftime
Copy link
Collaborator

Generate tests only if they dont exists

@VladIftime VladIftime requested review from lfse-slafleur and Flix6x and removed request for lfse-slafleur January 8, 2025 11:11
Flix6x
Flix6x previously requested changes Jan 8, 2025
Copy link
Collaborator

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Besides a leftover breakpoint I only have a minor suggestion to refactor.

development_utilities/gen_unit_test_template.py Outdated Show resolved Hide resolved
development_utilities/gen_unit_test_template.py Outdated Show resolved Hide resolved
Copy link
Member

@lfse-slafleur lfse-slafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once requested changes of @Flix6x are resolved, this is approved.

@Flix6x Flix6x dismissed their stale review January 16, 2025 09:29

Resolved the issues myself.

@Flix6x Flix6x merged commit c35b7e4 into main Jan 16, 2025
19 checks passed
@Flix6x Flix6x deleted the Dev-VladIftime-Kiflin-utils branch January 16, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants