Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gr_poly_scalar_mul ? #2159

Open
rburing opened this issue Jan 14, 2025 · 1 comment · May be fixed by #2191
Open

gr_poly_scalar_mul ? #2159

rburing opened this issue Jan 14, 2025 · 1 comment · May be fixed by #2191

Comments

@rburing
Copy link
Contributor

rburing commented Jan 14, 2025

This may be a bit of a corner case, but for a polynomial ring over a matrix ring one might want to multiply by a "constant" (i.e. a matrix) on the left instead of on the right (as gr_poly_mul_scalar does), see e.g. https://gitlab.inria.fr/ricardo-thomas.buring/d-finite-fun/-/blob/463d254ded0f4fc78fcae16ead856fa7e5e72be3/newton_iteration_flint.c#L258-L267

@fredrik-johansson
Copy link
Collaborator

There should be separate gr_poly_scalar_mul (scalar on the left) and gr_poly_mul_scalar (scalar on the right).

Likewise gr_poly_mul_other and gr_poly_other_mul.

There are some other places too where commutativity is assumed that ought to be fixed.

@rburing rburing changed the title gr_poly_mul_scalar_right ? gr_poly_scalar_mul ? Jan 14, 2025
@rburing rburing linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants