Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implement
GR_METHOD_OTHER_MUL
forgr_poly
.I was thinking of adding
gr_poly_mul_other
as mentioned in #2159 (comment) but I'm not sure how it should be done (or how useful it would be), since it would not have the polynomial ring context as input but only the base ring context. For example if the other is also a polynomial then it would not be possible to check if the variable names match (a check which is currently done in the methodsgr_mul_other
andgr_other_mul
implemented forgr_poly
).gr_poly_scalar_mul
? #2159