Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gr_poly_scalar_mul #2191

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

rburing
Copy link
Contributor

@rburing rburing commented Jan 27, 2025

Also implement GR_METHOD_OTHER_MUL for gr_poly.

I was thinking of adding gr_poly_mul_other as mentioned in #2159 (comment) but I'm not sure how it should be done (or how useful it would be), since it would not have the polynomial ring context as input but only the base ring context. For example if the other is also a polynomial then it would not be possible to check if the variable names match (a check which is currently done in the methods gr_mul_other and gr_other_mul implemented for gr_poly).

Also implement GR_METHOD_OTHER_MUL for gr_poly.
@fredrik-johansson
Copy link
Collaborator

Looks good!

I was thinking of adding gr_poly_mul_other as mentioned in #2159 (comment) but I'm not sure how it should be done (or how useful it would be), since it would not have the polynomial ring context as input but only the base ring context. For example if the other is also a polynomial then it would not be possible to check if the variable names match (a check which is currently done in the methods gr_mul_other and gr_other_mul implemented for gr_poly).

Yes, good point. I think it would be reasonable for set_other, mul_other (etc.) methods here to accept any univariate polynomial type and ignore the variable name.

Maybe later a basic interface for working with gr_poly_t wrt. a polynomial ring context object rather than a scalar context object should be moved to the gr_poly module and made public.

@fredrik-johansson fredrik-johansson merged commit c846788 into flintlib:main Jan 27, 2025
10 of 12 checks passed
@rburing rburing deleted the gr_poly_scalar_mul branch January 27, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr_poly_scalar_mul ?
2 participants