Add typeOptions support for oneOf/Unions #43
Conversation
| oneOf: | ||
| - $ref: '#/components/schemas/ZonedTimeType' | ||
| - type: string | ||
| format: date-time # Bug: This doesn't actually change it from being a Text in the generated code |
There was a problem hiding this comment.
Ah interesting, is format getting ignored here because it's an inlined value instead of a named property?
There was a problem hiding this comment.
Oh nevermind, I see you mention that in the pr message
There was a problem hiding this comment.
Created an issue for this: #44
|
Would it be fairly straightforward to go ahead and add the same changes to tagged union now as well? It would be nice to have the consistency |
|
@OwenGraves It would be nice, but since it's not needed for the current issue we had, I'll just made #45 for it. Really, the whole design around inline schemas is duplicated and fragile and should be refactored. Since everything is potentially in flux in my eyes, I don't wanna be fixing issue we're not actually blocked on. |
We noticed that we couldn't adjust the list of derived classes for union types.
If the union contains a
ZonedTime, this is necessary sinceZonedTimedoesn'thave
Eq, which is part of the default deriving list.This PR adds
TypeOptionsto untagged unions (CodeGenUnion). It doesn't addthe support for tagged unions, that is left for upcoming work.
It also doesn't fix the
format: date-timeparsing for inline schemas, whichseems broken, as you can see that the new union in the test cases of this PR
contains a
T.Text, which it shouldn't.