Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ErrorLevel as argument #11

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Require ErrorLevel as argument #11

merged 1 commit into from
Jun 21, 2024

Conversation

ysangkok
Copy link
Contributor

The error level is very useful as Rollbar has different icons for the different messages, making it easier to filter/spot critical messages.

I also bumped bounds to make this compatible with newer libraries.

Tested with:

cabal build -w ghc-9.8.2 -c 'text>=2.1' -c 'network>=3.2' -c 'aeson>=2.2'

I removed the network-bsd dependency as it is used only for a type synonym, which is not worth the cost of having the dependency (which is unmaintained).

@ysangkok ysangkok merged commit 5639bb0 into master Jun 21, 2024
1 check passed
@ysangkok ysangkok deleted the error-level branch June 21, 2024 22:38
@telser
Copy link

telser commented Jun 24, 2024

I removed the network-bsd dependency as it is used only for a type synonym, which is not worth the cost of having the dependency (which is unmaintained).

Is it unmaintained or is it just that the netdb.h interface from POSIX is super stable? Removing it from a dependency here seems fine, just curious.

@ysangkok
Copy link
Contributor Author

ysangkok commented Jun 24, 2024

It has major version bound bumps that are done by trustees, instead of the designated Hackage maintainers. When the Hackage maintainers don't do the work, I call the package unmaintained.

These bumps have been requested regularly since hvr left in 2020:

AFAIK Andreas Abel is not actually a maintainer, but he does have the commit bit and he is a Hackage trustee. So effectively he can do all that is necessary to update the package. But yesterdays bump was done by Bodigrim (also a trustee): https://hackage.haskell.org/package/network-bsd-2.8.1.0/revisions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants