[backport] feature: delete codebase when gateway is deleted (#394)

Signed-off-by: Lin Yang <[email protected]>

pkg/controllers/gateway/v1/gateway_controller.go

@@ -151,6 +151,10 @@ func (r *gatewayReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 			}.String())
 			r.mutex.Unlock()
 
+			if _, err := r.fctx.RepoClient.DeleteCodebase(utils.GatewayCodebasePath(req.Namespace, req.Name)); err != nil {
+				log.Warn().Msgf("Failed to delete codebase of gateway %s/%s: %s", req.Namespace, req.Name, err)
+			}
+
 			return ctrl.Result{}, nil
 		}
 		// Error reading the object - requeue the request.
@@ -165,6 +169,10 @@ func (r *gatewayReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 		delete(r.activeGateways, client.ObjectKeyFromObject(gateway).String())
 		r.mutex.Unlock()
 
+		if _, err := r.fctx.RepoClient.DeleteCodebase(utils.GatewayCodebasePath(gateway.Namespace, gateway.Name)); err != nil {
+			log.Warn().Msgf("Failed to delete codebase of gateway %s/%s: %s", gateway.Namespace, gateway.Name, err)
+		}
+
 		return ctrl.Result{}, nil
 	}
 

pkg/repo/client.go

@@ -216,6 +216,26 @@ func (p *PipyRepoClient) upsertFile(path string, content interface{}) error {
 	return fmt.Errorf(errstr, resp.StatusCode(), resp.Status())
 }
 
+// DeleteCodebase delete codebase
+func (p *PipyRepoClient) DeleteCodebase(path string) (success bool, err error) {
+	var resp *resty.Response
+
+	resp, err = p.httpClient.R().
+		Delete(fullRepoApiPath(path))
+
+	if err == nil {
+		if resp.IsSuccess() {
+			success = true
+			return
+		}
+		err = fmt.Errorf("error happened while deleting codebase[%s], reason: %s", path, resp.Status())
+		return
+	}
+
+	log.Err(err).Msgf("error happened while deleting codebase[%s]", path)
+	return
+}
+
 // deleteFile delete codebase file
 func (p *PipyRepoClient) deleteFile(path string) (success bool, err error) {
 	var resp *resty.Response
@@ -228,11 +248,11 @@ func (p *PipyRepoClient) deleteFile(path string) (success bool, err error) {
 			success = true
 			return
 		}
-		err = fmt.Errorf("error happened while deleting codebase[%s], reason: %s", path, resp.Status())
+		err = fmt.Errorf("error happened while deleting file %q, reason: %s", path, resp.Status())
 		return
 	}
 
-	log.Err(err).Msgf("error happened while deleting codebase[%s]", path)
+	log.Err(err).Msgf("error happened while deleting file %q", path)
 	return
 }