Miscellaneous 1.4 and 1.5 fixes #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shudongz @kenchiang Not sure what is going on because I don't have access to logs. Can you please give me a hand ? Thanks |
| uint32_t role; | ||
| // TODO support embedding of_header | ||
| of_octets_t data; | ||
| of_header_t request; |
There was a problem hiding this comment.
The build of the C-library currently fails, because of_header_t is not defined.
Traceback (most recent call last):
File "./loxigen.py", line 176, in <module>
lang_module.generate(options.install_dir)
File "/home/bsn/workspace/Organization_loxigen_PR-636-IVHAZVYHIZ5OV4QL2OQZ7AR7AOERX5COOOHWIZVMSQFMDJ7WHSOQ/lang_c.py", line 125, in generate
fn(outfile, os.path.basename(name))
File "/home/bsn/workspace/Organization_loxigen_PR-636-IVHAZVYHIZ5OV4QL2OQZ7AR7AOERX5COOOHWIZVMSQFMDJ7WHSOQ/c_gen/c_test_gen.py", line 1796, in dup_c_gen
gen_version_dup(out)
File "/home/bsn/workspace/Organization_loxigen_PR-636-IVHAZVYHIZ5OV4QL2OQZ7AR7AOERX5COOOHWIZVMSQFMDJ7WHSOQ/c_gen/c_test_gen.py", line 1739, in gen_version_dup
gen_dup_cls(out, cls, version)
File "/home/bsn/workspace/Organization_loxigen_PR-636-IVHAZVYHIZ5OV4QL2OQZ7AR7AOERX5COOOHWIZVMSQFMDJ7WHSOQ/c_gen/c_test_gen.py", line 1657, in gen_dup_cls
""" % dict(m_type=m_type, v_name=var_name_map(m_type)))
File "/home/bsn/workspace/Organization_loxigen_PR-636-IVHAZVYHIZ5OV4QL2OQZ7AR7AOERX5COOOHWIZVMSQFMDJ7WHSOQ/c_gen/c_test_gen.py", line 121, in var_name_map
return _var_name_map[m_type]
KeyError: 'of_header_t'
There was a problem hiding this comment.
(you should see the same result if you run make on your local code).
andi-bigswitch
requested changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.