Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor view_with_permissions as a utility function #106

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

florimondmanca
Copy link
Owner

Prompted by #102 (comment)

@florimondmanca florimondmanca added the refactor Issues and PRs relative to code refactoring label Feb 5, 2020
@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #106 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #106      +/-   ##
=========================================
+ Coverage   96.37%   96.6%   +0.22%     
=========================================
  Files          21      22       +1     
  Lines         469     471       +2     
=========================================
+ Hits          452     455       +3     
+ Misses         17      16       -1
Impacted Files Coverage Δ
tests/conftest.py 98.03% <ø> (-0.35%) ⬇️
tests/test_permissions_custom.py 100% <100%> (ø) ⬆️
tests/test_permissions.py 98.36% <100%> (+0.02%) ⬆️
tests/utils.py 100% <100%> (ø)
tests/test_permissions_combination.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851aec1...8f5a445. Read the comment docs.

@florimondmanca florimondmanca merged commit 19ce924 into master Feb 5, 2020
@florimondmanca florimondmanca deleted the tests-create-view branch February 5, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues and PRs relative to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants