Add support for upgrading API key hashes #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
fm/hasher-setter
branch
from
bc203a3
to
d9ad549
Compare
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
===========================================
- Coverage 100.00% 99.16% -0.84%
===========================================
Files 24 24
Lines 595 602 +7
===========================================
+ Hits 595 597 +2
- Misses 0 5 +5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Closing as this is irrevelant if we go with the DRF-api-key-specific SHA512 hasher as in #244. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out while working on #173 (comment)
Currently, if
PASSWORD_HASHERSchanges and hasher A (eg. PBKDF2) previously used to hash API keys is moved lower in the list than another hasher B (eg. Argon2), then API key hashes won't be upgraded.This PR adds support for this, by implementing
verify(..., setter=...).Needs some tests...