Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server's request timeout configurable #211

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Make server's request timeout configurable #211

merged 1 commit into from
Nov 16, 2021

Conversation

nanuuki
Copy link
Contributor

@nanuuki nanuuki commented Nov 15, 2021

Note; Disables WriteTimeout and ReadTimeout in favor of TimeoutHandler.

Related to the issue described in #199

@nanuuki
Make server's request timeout configurable
eeb41d6 
Disable WriteTimeout and ReadTimeout in favor of TimeoutHandler.
@nanuuki nanuuki added enhancement New feature or request config/parameters labels Nov 15, 2021
@nanuuki nanuuki requested a review from latenssi November 15, 2021 07:58
latenssi
latenssi approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@latenssi latenssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nanuuki nanuuki merged commit b2c91ad into main Nov 16, 2021
@nanuuki nanuuki deleted the feature/request-timeout-config branch November 16, 2021 10:50
@nanuuki nanuuki mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latenssi latenssi latenssi approved these changes

Assignees
No one assigned
Labels
config/parameters enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanuuki @latenssi