Replaced iterator_to_array with foreach in benchmarks

flow-php · Oct 16, 2023 · 0ec4a26 · 0ec4a26
1 parent 32c77ec
commit 0ec4a26
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 6 deletions.
diff --git a/...apter/etl-adapter-avro/tests/Flow/ETL/Adapter/Avro/Tests/Benchmark/AvroExtractorBench.php b/...apter/etl-adapter-avro/tests/Flow/ETL/Adapter/Avro/Tests/Benchmark/AvroExtractorBench.php
@@ -16,6 +16,7 @@ final class AvroExtractorBench
     #[Revs(5)]
     public function bench_extract_10k() : void
     {
-        \iterator_to_array(Avro::from(__DIR__ . '/../Fixtures/orders_flow.avro')->extract(new FlowContext(Config::default())));
+        foreach (Avro::from(__DIR__ . '/../Fixtures/orders_flow.avro')->extract(new FlowContext(Config::default())) as $rows) {
+        }
     }
 }
diff --git a/src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Benchmark/CSVExtractorBench.php b/src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Benchmark/CSVExtractorBench.php
@@ -16,6 +16,7 @@ final class CSVExtractorBench
     #[Revs(5)]
     public function bench_extract_10k() : void
     {
-        \iterator_to_array(CSV::from(__DIR__ . '/../Fixtures/orders_flow.csv')->extract(new FlowContext(Config::default())));
+        foreach (CSV::from(__DIR__ . '/../Fixtures/orders_flow.csv')->extract(new FlowContext(Config::default())) as $rows) {
+        }
     }
 }
diff --git a/...apter/etl-adapter-json/tests/Flow/ETL/Adapter/JSON/Tests/Benchmark/JsonExtractorBench.php b/...apter/etl-adapter-json/tests/Flow/ETL/Adapter/JSON/Tests/Benchmark/JsonExtractorBench.php
@@ -16,6 +16,7 @@ final class JsonExtractorBench
     #[Revs(5)]
     public function bench_extract_10k() : void
     {
-        \iterator_to_array(Json::from(__DIR__ . '/../Fixtures/orders_flow.json')->extract(new FlowContext(Config::default())));
+        foreach (Json::from(__DIR__ . '/../Fixtures/orders_flow.json')->extract(new FlowContext(Config::default())) as $rows) {
+        }
     }
 }
diff --git a/...-adapter-parquet/tests/Flow/ETL/Adapter/Parquet/Tests/Benchmark/ParquetExtractorBench.php b/...-adapter-parquet/tests/Flow/ETL/Adapter/Parquet/Tests/Benchmark/ParquetExtractorBench.php
@@ -16,6 +16,7 @@ final class ParquetExtractorBench
     #[Revs(5)]
     public function bench_extract_10k() : void
     {
-        \iterator_to_array(Parquet::from(__DIR__ . '/../Fixtures/orders_flow.parquet')->extract(new FlowContext(Config::default())));
+        foreach (Parquet::from(__DIR__ . '/../Fixtures/orders_flow.parquet')->extract(new FlowContext(Config::default())) as $rows) {
+        }
     }
 }
diff --git a/...apter/etl-adapter-text/tests/Flow/ETL/Adapter/Text/Tests/Benchmark/TextExtractorBench.php b/...apter/etl-adapter-text/tests/Flow/ETL/Adapter/Text/Tests/Benchmark/TextExtractorBench.php
@@ -16,6 +16,7 @@ final class TextExtractorBench
     #[Revs(5)]
     public function bench_extract() : void
     {
-        \iterator_to_array(Text::from(__DIR__ . '/../Fixtures/annual-enterprise-survey-2019-financial-year-provisional-csv.csv')->extract(new FlowContext(Config::default())));
+        foreach (Text::from(__DIR__ . '/../Fixtures/annual-enterprise-survey-2019-financial-year-provisional-csv.csv')->extract(new FlowContext(Config::default())) as $rows) {
+        }
     }
 }
diff --git a/src/adapter/etl-adapter-xml/tests/Flow/ETL/Adapter/XML/Tests/Benchmark/XmlExtractorBench.php b/src/adapter/etl-adapter-xml/tests/Flow/ETL/Adapter/XML/Tests/Benchmark/XmlExtractorBench.php
@@ -16,6 +16,7 @@ final class XmlExtractorBench
     #[Revs(5)]
     public function bench_extract() : void
     {
-        \iterator_to_array(XML::from(__DIR__ . '/../Fixtures/simple_items.xml')->extract(new FlowContext(Config::default())));
+        foreach (XML::from(__DIR__ . '/../Fixtures/simple_items.xml')->extract(new FlowContext(Config::default())) as $rows) {
+        }
     }
 }