Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed casting DateTime objects into datetime/date #1031

Merged

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • casting DateTime objects into datetime/date

Changed

Removed

Deprecated

Security


Description

Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.282mb +0.00%  | 828.883ms +0.70% | ±0.47% -65.81%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.005mb +0.01%   | 347.887ms +1.52% | ±1.59% +433.09% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.156mb +0.01%   | 1.049s -0.62%    | ±0.50% +133.08% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.831mb +0.00% | 907.204ms -0.27% | ±0.70% -30.62%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.913mb +0.01%   | 35.572ms +0.33%  | ±0.25% -20.72%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.919mb +0.01%   | 430.405ms -1.21% | ±0.25% -80.89%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.619mb +0.00% | 65.687ms -0.64% | ±1.04% +116.47% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.663mb +0.00%  | 475.190ms +1.73% | ±0.41% -69.37%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.144mb +0.00%  | 71.839ms -1.36%  | ±0.67% +144.12% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.570mb +0.00% | 53.069ms +0.96%  | ±0.17% -72.41%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 224.394mb +0.00% | 1.417s -2.29%    | ±0.20% -75.72%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.960mb +0.00%  | 40.670ms +0.23%  | ±0.32% -16.29%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.686mb +0.00%  | 3.334ms -9.65%   | ±1.71% +17.65%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.413mb +0.00%  | 184.391ms -0.20% | ±0.81% +18.08%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.938mb +0.00%  | 18.263ms -3.55%  | ±0.84% +117.69% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.926mb +0.00%  | 1.692ms -14.09%  | ±1.86% -39.11%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.926mb +0.00%  | 1.676ms -7.17%   | ±1.43% -52.61%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.038mb +0.00%  | 2.523ms -9.26%   | ±2.93% +37.66%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.567mb +0.00%  | 14.401ms -5.20%  | ±2.40% +404.67% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.567mb +0.00%  | 14.328ms -6.65%  | ±3.31% +455.45% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.471mb +0.00%  | 1.700μs -15.00%  | ±0.00% 0.00%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.471mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.025mb +0.00%  | 13.270ms -14.28% | ±0.90% -33.78%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.386mb +0.00% | 66.290ms -1.27%  | ±1.13% -15.15%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.086mb +0.00%  | 1.589ms +2.48%   | ±2.01% -32.19%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.433mb +0.00%  | 59.534ms -1.05%  | ±1.38% +122.42% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.188mb +0.00%  | 4.004ms -1.47%   | ±0.32% -90.73%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.549mb +0.00%  | 40.083ms -6.25%  | ±0.42% -48.13%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.550mb +0.00%  | 40.450ms -5.48%  | ±0.94% -17.00%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.549mb +0.00%  | 40.636ms -4.31%  | ±0.16% -93.89%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.912mb +0.00%  | 7.521ms -5.12%   | ±0.27% -91.24%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.471mb +0.00%  | 29.402ms -2.91%  | ±1.49% -37.80%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.471mb +0.00%  | 13.538μs -3.37%  | ±2.73% -13.35%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.471mb +0.00%  | 16.380μs -5.14%  | ±1.03% -56.97%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.479mb +0.00%  | 189.047ms +0.44% | ±2.38% +195.76% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.718mb +0.00% | 493.073ms -1.84% | ±0.32% -74.35%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.196mb +0.00%  | 249.881ms +0.29% | ±1.03% +57.70%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.130mb +0.00%  | 53.796ms +1.40%  | ±0.92% -68.30%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.961mb +0.00%  | 436.067ms -0.76% | ±0.67% -28.50%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.500mb +0.00%  | 87.034ms -0.75%  | ±1.25% +67.20%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 0cf5840 into flow-php:1.x Mar 29, 2024
17 checks passed
@norberttech norberttech deleted the bug/fixed-casting-datetime-objects branch May 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant