Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for PHPUnit 11 #1087

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented May 25, 2024

Change Log

Added

Fixed

Changed

  • Prepare for PHPUnit 11

Removed

Deprecated

Security


Description

In PHPUnit 11 usage of docbook annotations is deprecated.

@stloyd stloyd changed the title Migrate to PHPUnit 11 Prepare for PHPUnit 11 May 25, 2024
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.449mb +0.00%  | 880.569ms +6.45% | ±0.74% +70.44%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.167mb +0.00%   | 350.514ms +4.23% | ±1.00% +71.93%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.200mb +0.00%   | 1.116s +3.56%    | ±1.38% +162.52% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.872mb +0.00% | 1.073s +18.09%   | ±0.69% -16.65%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.958mb +0.00%   | 36.098ms -0.52%  | ±0.82% -16.17%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.963mb +0.00%   | 441.939ms -1.98% | ±1.09% -33.46%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode              | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.265mb +0.00% | 115.321ms +91.56% | ±1.77% +34.17% |
+-----------------------------+--------------------------+------+-----+------------------+-------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+--------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode               | rstdev          |
+--------------------+----------------+------+-----+------------------+--------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 96.834mb +0.00%  | 571.249ms +28.01%  | ±0.61% -23.03%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.246mb +0.00%  | 120.084ms +75.95%  | ±3.01% +820.02% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 107.620mb +0.00% | 105.090ms +104.75% | ±3.07% +606.98% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 227.039mb +0.00% | 1.679s +19.14%     | ±1.09% +9.04%   |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.001mb +0.00%  | 45.845ms +17.47%   | ±1.37% +20.03%  |
+--------------------+----------------+------+-----+------------------+--------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.083mb +0.00%  | 3.809ms +12.94%   | ±3.04% +59.85%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.681mb +0.00% | 276.448ms +45.56% | ±2.29% +215.50%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.401mb +0.00%  | 19.391ms +0.07%   | ±2.54% +274.72%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.323mb +0.00%  | 1.825ms +5.05%    | ±1.41% +6.89%    |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.323mb +0.00%  | 2.005ms +16.60%   | ±0.97% +64.89%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.435mb +0.00%  | 3.570ms +25.73%   | ±0.65% -80.37%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.964mb +0.00%  | 21.503ms +33.04%  | ±3.21% +545.80%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.964mb +0.00%  | 22.135ms +35.49%  | ±2.32% -33.23%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.868mb +0.00%  | 2.594μs +53.13%   | ±1.84% -35.06%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.868mb +0.00%  | 0.500μs +25.00%   | ±0.00% -100.00%  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.218mb +0.00%  | 13.320ms +8.53%   | ±0.64% +79.51%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.589mb +0.00% | 109.568ms +77.97% | ±0.62% -41.21%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.484mb +0.00%  | 1.499ms +4.96%    | ±2.52% -25.29%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.831mb +0.00%  | 92.575ms +46.84%  | ±2.21% +148.76%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.585mb +0.00%  | 4.610ms +8.97%    | ±1.66% -4.39%    |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.012mb +0.00%  | 40.666ms +2.97%   | ±2.35% +242.94%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.012mb +0.00%  | 40.268ms +3.10%   | ±3.39% +416.34%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.012mb +0.00%  | 40.837ms -1.72%   | ±0.96% -17.85%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.309mb +0.00%  | 7.882ms +7.91%    | ±2.93% +1102.12% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.868mb +0.00%  | 29.058ms +2.10%   | ±0.79% +71.19%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.868mb +0.00%  | 17.776μs +29.64%  | ±2.91% +50.18%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.868mb +0.00%  | 20.465μs +25.39%  | ±2.07% +169.64%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.682mb +0.00% | 300.218ms +55.75% | ±1.15% +63.01%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.813mb +0.00% | 575.568ms +14.40% | ±1.68% +83.66%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.291mb +0.00%  | 281.069ms +11.36% | ±0.32% -90.69%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.225mb +0.00%  | 59.317ms +10.69%  | ±3.67% +642.56%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.996mb +0.00%  | 502.841ms +15.94% | ±2.23% +959.92%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.535mb +0.00%  | 88.363ms +1.92%   | ±2.64% +122.16%  |
+-------------------------+----------------------------+------+-----+------------------+-------------------+------------------+

@norberttech norberttech merged commit a2bf5c3 into flow-php:1.x Jun 1, 2024
23 checks passed
@stloyd stloyd deleted the migrate-phpunit11 branch June 1, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants