Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify making schema definitions nullable #1110

Merged

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Simplify making schema definitions nullable

Removed

Deprecated

  • Schema::nullable() in favor of Schema::makeNullable()
  • Definition::nullable() in favor of Definition::makeNullable(bool $nullable)

Security


Description

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 3.914mb +0.00%   | 506.767ms -1.46% | ±0.69% -53.33% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 3.947mb +0.00%   | 1.078s +0.71%    | ±1.82% +16.68% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.388mb +0.00% | 736.847ms -1.58% | ±0.66% +73.12% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 3.674mb +0.01%   | 33.701ms -0.05%  | ±0.70% -0.14%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 3.621mb +0.01%   | 432.865ms -1.12% | ±0.27% -84.24% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 115.967mb +0.00% | 59.912ms +0.42% | ±0.95% +78.05% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev         |
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.069mb +0.00%  | 86.670ms +1.05% | ±1.82% -9.05%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.502mb +0.00% | 52.684ms -0.49% | ±0.06% -75.15% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 225.845mb +0.00% | 1.406s -2.19%   | ±0.29% -69.52% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.863mb +0.00%  | 44.442ms +0.02% | ±0.58% -56.93% |
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.517mb +0.00% | 524.274ms +6.12% | ±3.12% +153.26% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.995mb +0.00%  | 244.028ms -3.32% | ±1.15% +45.48%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.929mb +0.00%  | 55.478ms +2.14%  | ±2.56% +198.69% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.695mb +0.00%  | 433.784ms +0.19% | ±1.14% +17.54%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.235mb +0.00%  | 86.438ms +0.27%  | ±0.61% -14.50%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 86.787mb +0.00%  | 3.405ms -3.92%   | ±2.44% +192.26% |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.385mb +0.00% | 190.341ms +2.15% | ±0.49% -43.32%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.105mb +0.00%  | 19.004ms -0.11%  | ±0.73% +3.10%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.027mb +0.00%  | 1.781ms -0.86%   | ±3.04% -3.33%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.027mb +0.00%  | 2.069ms +14.72%  | ±3.68% +52.78%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.139mb +0.00%  | 2.790ms -1.59%   | ±1.90% +77.88%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.668mb +0.00%  | 16.651ms +11.51% | ±2.46% +238.80% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.668mb +0.00%  | 17.335ms +15.95% | ±0.90% -26.20%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.572mb +0.00%  | 1.600μs -11.11%  | ±0.00% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.572mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 92.922mb +0.00%  | 11.929ms -5.55%  | ±0.64% -56.75%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.292mb +0.00% | 61.315ms -4.24%  | ±2.59% +188.08% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.187mb +0.00%  | 1.218ms -24.68%  | ±3.15% -15.99%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.534mb +0.00%  | 63.284ms -3.99%  | ±1.27% +15.00%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.289mb +0.00%  | 3.899ms -8.50%   | ±0.92% -39.95%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.715mb +0.00%  | 38.954ms +0.54%  | ±1.04% -38.42%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.716mb +0.00%  | 39.036ms -0.65%  | ±0.50% -44.09%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.715mb +0.00%  | 39.280ms -2.66%  | ±0.19% -89.59%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.013mb +0.00%  | 7.414ms +0.29%   | ±1.42% +97.87%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.572mb +0.00%  | 28.442ms -4.28%  | ±0.53% -33.65%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.572mb +0.00%  | 13.300μs -3.58%  | ±0.00% -100.00% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.572mb +0.00%  | 15.606μs -6.67%  | ±0.30% -59.71%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.386mb +0.00% | 191.761ms +1.11% | ±0.45% -63.59%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 2dceb40 into flow-php:1.x Jul 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant