Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symfony http foundation bridge - flow streamed response #1234

Merged

Conversation

norberttech
Copy link
Member

@norberttech norberttech commented Sep 26, 2024

Change Log

Added

  • symfony streamed response
  • Possibility to use different output streams in StdOutFilesystem

Fixed

  • Path to bridges unit/integration test cases in phpunit.xml

Changed

  • Path options are now available as a Options object instead of PHP associative array

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.559mb +1.60%  | 517.712ms +1.16% | ±0.55% +80.72%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.673mb +0.96%  | 1.066s -1.62%    | ±0.49% -43.18%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 29.130mb +0.15% | 437.534ms +0.73% | ±1.38% +112.41% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.315mb +1.04%  | 34.371ms +1.62%  | ±0.71% +1.29%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.297mb +1.04%  | 667.833ms -0.32% | ±1.24% +156.50% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.591mb +0.09% | 59.786ms -0.57% | ±1.07% +41.00% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.756mb +0.13%  | 123.214ms +0.20% | ±0.79% +27.72%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.365mb +0.05%  | 102.450ms +1.38% | ±1.36% +286.65% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.485mb +0.04% | 1.244s -0.36%    | ±0.33% -73.21%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.506mb +0.26%  | 29.038ms +0.23%  | ±0.32% -61.91%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.229mb +0.08%  | 394.011ms -0.56% | ±0.53% -63.27%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.495mb +0.30%  | 78.920ms +0.21%  | ±0.44% -39.59%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.426mb +0.04% | 487.233ms +4.14% | ±2.32% +48.60%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.784mb +0.07%  | 237.503ms -1.23% | ±1.10% -54.05%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.622mb +0.28%  | 51.883ms +0.37%  | ±0.82% -21.09%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.405mb +0.05%  | 3.602ms +7.75%   | ±0.37% -32.83%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.943mb +0.04% | 192.264ms +1.31% | ±1.13% +504.59% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.663mb +0.05%  | 19.897ms +5.68%  | ±0.23% -81.69%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.644mb +0.05%  | 2.071ms +11.15%  | ±3.16% +4.21%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.644mb +0.05%  | 2.119ms +11.08%  | ±2.72% -25.29%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.757mb +0.05%  | 2.959ms +6.71%   | ±2.19% -4.79%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.286mb +0.05%  | 17.147ms +5.29%  | ±0.97% -35.00%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.286mb +0.05%  | 17.141ms +5.59%  | ±1.32% -30.32%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.189mb +0.05%  | 1.800μs +6.26%   | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.189mb +0.05%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.540mb +0.04%  | 13.264ms +5.93%  | ±1.13% +179.97% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.910mb +0.03% | 62.268ms +0.81%  | ±0.41% -49.52%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.805mb +0.05%  | 1.779ms +28.94%  | ±2.19% +14.41%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.096mb +0.04%  | 65.069ms +12.08% | ±0.46% -39.73%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.907mb +0.05%  | 4.454ms +6.69%   | ±0.34% +0.62%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.273mb +0.05%  | 38.923ms -1.99%  | ±1.21% +109.93% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.274mb +0.05%  | 39.715ms +2.11%  | ±0.54% -41.65%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.273mb +0.05%  | 39.860ms +0.46%  | ±0.90% -4.66%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.631mb +0.05%  | 7.482ms -0.18%   | ±0.72% -55.49%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.189mb +0.05%  | 28.787ms +0.09%  | ±1.35% +94.21%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.189mb +0.05%  | 14.201μs +5.95%  | ±3.45% +16.78%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.189mb +0.05%  | 16.358μs +1.47%  | ±1.78% +129.84% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.944mb +0.04% | 195.396ms +2.15% | ±0.71% -19.07%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech force-pushed the feature/symfony-streamed-resposne branch 2 times, most recently from 2e248ed to 1648837 Compare September 26, 2024 19:57
@norberttech norberttech force-pushed the feature/symfony-streamed-resposne branch from a86e7b2 to 363234d Compare September 26, 2024 20:19
@norberttech norberttech merged commit 1354e43 into flow-php:1.x Sep 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant