Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when bytes are missing in Parquet BinaryBufferReader #583

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Oct 13, 2023

Change Log

Added

Fixed

  • Fix warning when bytes are missing in Parquet `BinaryBufferReader`

Changed

Removed

Deprecated

Security


Description

Detected by PHPUnit (with options: stopOnWarning="true" displayDetailsOnTestsThatTriggerWarnings="true" - ref #584) - https://github.com/flow-php/flow/actions/runs/6512389583/job/17689920950?pr=584#step:10:44

1) /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/BinaryReader/BinaryBufferReader.php:61
Uninitialized string offset 13

Triggered by:

* Flow\Parquet\Tests\Integration\ListsReadingTest::test_reading_list_of_structures_column
  /Users/stloyd/Documents/flow/src/lib/parquet/tests/Flow/Parquet/Tests/Integration/ListsReadingTest.php:96

...

37) /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/BinaryReader/BinaryBufferReader.php:61
Uninitialized string offset 49

Triggered by:

* Flow\Parquet\Tests\Integration\ListsReadingTest::test_reading_list_of_structures_column
  /Users/stloyd/Documents/flow/src/lib/parquet/tests/Flow/Parquet/Tests/Integration/ListsReadingTest.php:96

@norberttech norberttech merged commit 04589b3 into flow-php:1.x Oct 13, 2023
16 checks passed
@stloyd stloyd deleted the bugfix/parquet-binary branch October 13, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants