Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced total available memory to make sure that MemorySort is doing a fallback to cache #599

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Reduced total available memory to make sure that MemorySort is doing a fallback to cache #599

merged 1 commit into from
Oct 16, 2023

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • Reduced total available memory to make sure that MemorySort is doing a fallback to cache

Changed

Removed

Deprecated

Security

Description

@norberttech
Copy link
Member Author

It seems that this can happen when current memory consumption is not exceeding the available limit, then whole sorting occurs in memory, and cache is not used at all, and the failing test is about the cache usage.
What I still don't understand is why it started just now, but it might be related to optimizations of NativeEntryFactory.

@norberttech norberttech enabled auto-merge (squash) October 16, 2023 15:45
@norberttech norberttech merged commit d0b5649 into flow-php:1.x Oct 16, 2023
14 checks passed
@stloyd stloyd mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@norberttech