Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust benchmark report to be more useful #604

Merged
merged 1 commit into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/benchmark-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
fi
- name: "Checkout to specific ref"
uses: "actions/checkout@v2"
uses: "actions/checkout@v4"
with:
ref: ${{ env.GIT_REF }}

Expand All @@ -63,14 +63,6 @@ jobs:
php-version: "${{ matrix.php-version }}"
ini-values: memory_limit=-1

- name: "Install PHP"
uses: "shivammathur/setup-php@v2"
with:
coverage: none
tools: composer:v2
php-version: "${{ matrix.php-version }}"
ini-values: memory_limit=-1

- name: "Get Composer Cache Directory"
id: composer-cache
run: |
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/test-benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
- 'src/core/**'
- 'src/lib/**'
- 'tools/**'
- 'composer.json'
- 'composer.lock'

jobs:
Expand Down Expand Up @@ -96,4 +97,4 @@ jobs:
echo '---' >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
composer test:benchmark -- --ref=1.x --progress=none --group=entry_factory >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
"tools/phpunit/vendor/bin/phpunit"
],
"test:benchmark": [
"tools/phpbench/vendor/bin/phpbench run --report=aggregate --retry-threshold=5"
"tools/phpbench/vendor/bin/phpbench run --report=flow-report"
],
"test:mutation": [
"tools/infection/vendor/bin/infection -j2"
Expand Down
14 changes: 14 additions & 0 deletions phpbench.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
{
"$schema": "./tools/phpbench/vendor/phpbench/phpbench/phpbench.schema.json",
"runner.bootstrap": "vendor/autoload.php",
"report.generators": {
"flow-report": {
"generator": "expression",
"cols": {
"benchmark": null,
"subject": null,
"revs": null,
"its": null,
"mem_peak": null,
"mode": null
}
}
},
"runner.path": [
"src/adapter/etl-adapter-avro/tests/Flow/ETL/Adapter/Avro/Tests/Benchmark/",
"src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Benchmark/",
Expand All @@ -11,5 +24,6 @@
"src/core/etl/tests/Flow/ETL/Tests/Benchmark/"
],
"runner.progress": "dots",
"runner.retry_threshold": 5,
"storage.xml_storage_path": "var/phpbench"
}
Loading