Remove array_merge() from constructors when not needed
#625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
force-pushed
the
chore/array-merge-clean
branch
from
76d07b4
to
01bd923
Compare
norberttech
reviewed
Oct 22, 2023
| @@ -18,9 +19,13 @@ final class All implements Comparison | |||
| */ | |||
| private array $comparisons; | |||
|
|
|||
| public function __construct(Comparison $comparison, Comparison ...$comparisons) | |||
| public function __construct(Comparison ...$comparisons) | |||
There was a problem hiding this comment.
I prefer to keep it like it is now. This way, the constructor enforces at least one Comparison, so there is no need to write a unit test covering this edge case to satisfy mutation tests.
It's an approach commonly used in Scala when at least one element is required.
This particular array_merge should also have no impact on the pipeline processing performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description