Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to convert rows into array without keys #880

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

norberttech
Copy link
Member

@norberttech norberttech commented Dec 19, 2023

Change Log

Added

  • Added possibility to convert rows into array without keys
  • Monorepo test command

Fixed

Changed

  • Updated dependencies

Removed

Deprecated

Security


Description

Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev           |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.137mb +0.00%  | 718.027ms +2.05% | ±2.66% +1581.49% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.835mb +0.02%   | 304.681ms +0.21% | ±0.09% -73.17%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.934mb +0.02%   | 917.428ms -2.72% | ±1.00% -18.57%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.713mb +0.00% | 1.123s -0.11%    | ±0.10% -93.05%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.711mb +0.01%   | 27.501ms +1.12%  | ±2.51% +229.74%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.713mb +0.01%   | 412.469ms +0.32% | ±0.23% -86.55%   |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.407mb +0.00% | 63.888ms +1.07% | ±1.53% +139.85% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.805mb +0.00%  | 445.666ms -3.53% | ±1.12% +70.22%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.883mb +0.00%  | 72.538ms +5.24%  | ±0.79% +171.23% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.466mb +0.00% | 57.843ms +3.21%  | ±0.17% -88.15%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.675mb +0.00% | 1.271s +1.03%    | ±2.52% +77.96%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.760mb +0.01%  | 41.507ms -0.91%  | ±0.25% -74.22%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.043mb +0.00% | 380.141ms +1.85% | ±0.30% -88.38%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.761mb +0.00%  | 193.779ms +1.13% | ±0.94% +88.16%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.836mb +0.01%  | 40.339ms +1.76%  | ±2.69% +61.68%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.393mb +0.00%  | 338.431ms +2.06% | ±1.09% +195.53% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.316mb +0.00%  | 68.252ms +1.29%  | ±2.30% +0.85%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.457mb +0.00%  | 4.014ms +1.52%   | ±2.17% -2.71%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.250mb +0.00%  | 179.882ms -0.84% | ±2.11% +216.04% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.776mb +0.00%  | 18.818ms +4.03%  | ±1.77% -8.31%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.697mb +0.00%  | 1.824ms +6.39%   | ±2.70% +264.81% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.697mb +0.00%  | 1.785ms +4.25%   | ±1.41% +2.36%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.809mb +0.00%  | 2.713ms +4.10%   | ±3.54% +20.32%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.338mb +0.00%  | 15.263ms +1.33%  | ±1.55% +7.26%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.338mb +0.00%  | 14.955ms +3.72%  | ±0.87% -38.79%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.241mb +0.00%  | 1.794μs -0.67%   | ±2.67% +3.77%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.241mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.864mb +0.00%  | 13.343ms +6.00%  | ±3.42% +149.36% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.158mb +0.00% | 63.921ms +2.36%  | ±1.47% -28.65%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.858mb +0.00%  | 1.470ms +1.28%   | ±3.70% +5.45%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 78.132mb +0.00%  | 38.962ms +7.91%  | ±1.10% +38.49%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.959mb +0.00%  | 4.059ms +1.92%   | ±3.46% +69.97%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.386mb +0.00%  | 39.954ms -0.83%  | ±0.46% -29.75%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.387mb +0.00%  | 39.965ms +1.01%  | ±0.40% -52.74%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.386mb +0.00%  | 41.380ms +4.02%  | ±1.60% +267.24% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.684mb +0.00%  | 7.420ms +2.91%   | ±1.35% -21.35%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.241mb +0.00%  | 28.650ms -3.47%  | ±0.88% +53.08%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.241mb +0.00%  | 14.082μs +3.45%  | ±1.01% +46.43%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.241mb +0.00%  | 16.900μs +3.18%  | ±0.00% -100.00% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.251mb +0.00%  | 182.896ms -2.96% | ±0.56% -38.24%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 65d31fb into flow-php:1.x Dec 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment