Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed serialization issues related to various problems #896

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • Serialization of XMLElement and XMLNodeElement
  • Serialization of multiline strings with special characters

Changed

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Dec 31, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.140mb +0.00%  | 760.671ms +0.68% | ±2.17% +77.35%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.774mb +0.10%   | 343.435ms +0.71% | ±0.54% +183.22% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.868mb +0.05%   | 985.347ms +0.65% | ±0.80% -20.75%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.573mb +0.00% | 1.147s +0.40%    | ±0.32% -58.39%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.653mb +0.01%   | 57.292ms +1.09%  | ±0.51% -27.35%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.655mb +0.01%   | 470.535ms -0.12% | ±0.52% -28.97%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.368mb +0.00% | 64.072ms +1.75% | ±0.22% -39.10% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.731mb +0.00%  | 454.361ms +2.21% | ±0.16% -81.30%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.812mb +0.01%  | 72.179ms -0.37%  | ±1.17% -8.99%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.324mb +0.00% | 57.631ms +1.77%  | ±1.01% +57.30%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.535mb +0.00% | 1.265s -0.64%    | ±1.24% +113.25% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.695mb +0.01%  | 41.069ms -1.04%  | ±0.28% -43.68%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-------------------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev                        |
+-------------------------+----------------------------+------+-----+------------------+------------------+-------------------------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.991mb +0.00% | 400.479ms +1.02% | ±1.63% +465.67%               |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.710mb +0.00%  | 207.312ms +4.86% | ±2.05% +68.58%                |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.834mb +0.02%  | 42.504ms +2.49%  | ±2.17% +323.19%               |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.397mb +0.00%  | 332.498ms +0.70% | ±1.32% +174.31%               |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.320mb +0.00%  | 66.150ms +1.53%  | ±1.09% +316.74%               |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.456mb +0.00%  | 4.366ms +6.30%   | ±1.74% +31.95%                |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.248mb +0.00%  | 183.816ms +0.09% | ±0.71% +121.27%               |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.774mb +0.00%  | 18.377ms -2.25%  | ±0.25% -58.76%                |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.696mb +0.00%  | 1.887ms +4.82%   | ±3.72% +199.00%               |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.696mb +0.00%  | 1.866ms +0.36%   | ±3.00% +141.74%               |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.808mb +0.00%  | 2.848ms +2.10%   | ±1.78% -17.03%                |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.337mb +0.00%  | 15.437ms +3.65%  | ±1.57% +1.81%                 |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.337mb +0.00%  | 14.857ms -1.45%  | ±1.74% +208.89%               |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.240mb +0.00%  | 2.000μs +5.60%   | ±0.00% -100.00%               |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.240mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%                  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.795mb +0.00%  | 13.412ms -0.74%  | ±1.48% -31.96%                |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.156mb +0.00% | 65.140ms +2.16%  | ±1.30% +10.65%                |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.857mb +0.00%  | 1.430ms +1.16%   | ±2.40% +130.78%               |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.203mb +0.00%  | 58.484ms +0.44%  | ±1.01% +204.96%               |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.958mb +0.00%  | 4.092ms +2.96%   | ±1.76% +146.72%               |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.385mb +0.00%  | 39.949ms -3.28%  | ±0.29% -73.54%                |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.386mb +0.00%  | 39.775ms -3.14%  | ±0.70% -29.57%                |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.385mb +0.00%  | 39.900ms -4.16%  | ±0.28% -16.04%                |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.682mb +0.00%  | 7.387ms -6.14%   | ±1.58% -36.59%                |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.240mb +0.00%  | 29.658ms -0.09%  | ±0.62% -63.53%                |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.240mb +0.00%  | 13.824μs +0.18%  | ±1.35% +10513506349385000.00% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.240mb +0.00%  | 16.200μs -4.59%  | ±1.01% -62.75%                |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.250mb +0.00%  | 186.862ms +0.21% | ±0.22% -54.94%                |
+-------------------------+----------------------------+------+-----+------------------+------------------+-------------------------------+

@norberttech norberttech merged commit 1f81b3f into flow-php:1.x Dec 31, 2023
17 checks passed
@norberttech norberttech mentioned this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant