Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed writing uuid entries to parquet files #901

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

norberttech
Copy link
Member

@norberttech norberttech commented Jan 2, 2024

Change Log

Added

  • partition_by example

Fixed

  • writing uuid entries to parquet files

Changed

  • Return types of functions in DSL

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev           |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.129mb +0.00%  | 752.255ms -0.25% | ±0.56% +51.77%   |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.782mb +0.01%   | 347.365ms +0.76% | ±3.07% +2716.55% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.877mb +0.01%   | 980.569ms +0.56% | ±0.66% +32.54%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.581mb +0.00% | 1.140s +0.81%    | ±0.54% -39.00%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.661mb +0.01%   | 57.564ms +0.06%  | ±0.31% +214.55%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.663mb +0.01%   | 462.730ms -1.60% | ±0.43% -77.10%   |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.376mb +0.00% | 64.091ms -0.39% | ±0.52% +7.76% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.739mb +0.00%  | 452.174ms +1.11% | ±0.59% -33.78% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.820mb +0.00%  | 73.135ms +0.89%  | ±0.59% -22.21% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.332mb +0.00% | 57.329ms +2.21%  | ±0.35% +35.00% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.543mb +0.00% | 1.268s +1.07%    | ±0.58% -9.12%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.703mb +0.00%  | 41.054ms +0.23%  | ±0.11% -92.15% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.992mb +0.00% | 401.551ms +1.98% | ±1.66% +209.33% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.710mb +0.00%  | 196.053ms -0.59% | ±0.51% -34.48%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.835mb +0.00%  | 41.628ms -0.72%  | ±1.24% -7.68%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.398mb +0.00%  | 329.201ms +0.94% | ±0.26% +396.90% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.321mb +0.00%  | 65.281ms +0.72%  | ±0.57% -4.42%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.456mb +0.00%  | 3.811ms +0.79%   | ±0.79% -25.58%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.249mb +0.00%  | 189.192ms +4.68% | ±0.48% +85.28%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.775mb +0.00%  | 18.711ms -0.87%  | ±2.29% -5.99%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.696mb +0.00%  | 1.703ms +0.19%   | ±1.04% -60.44%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.696mb +0.00%  | 1.707ms +3.57%   | ±2.43% -15.66%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.808mb +0.00%  | 2.673ms +6.67%   | ±3.23% +290.98% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.337mb +0.00%  | 14.699ms -17.38% | ±1.55% +119.10% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.337mb +0.00%  | 14.328ms -19.83% | ±0.53% +31.19%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.240mb +0.00%  | 1.706μs -5.54%   | ±2.72% +5.77%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.240mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.796mb +0.00%  | 12.623ms -0.64%  | ±2.52% +192.40% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.157mb +0.00% | 63.989ms +0.33%  | ±0.81% -2.96%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.857mb +0.00%  | 1.247ms -5.67%   | ±2.94% -8.95%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.204mb +0.00%  | 57.453ms -1.91%  | ±0.93% -39.60%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.959mb +0.00%  | 3.848ms +0.24%   | ±1.44% +336.00% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.385mb +0.00%  | 40.522ms +2.21%  | ±1.33% +170.79% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.386mb +0.00%  | 40.831ms +2.71%  | ±1.46% +318.85% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.385mb +0.00%  | 41.296ms +0.99%  | ±1.02% -10.43%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.683mb +0.00%  | 7.456ms +0.47%   | ±0.63% -16.77%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.240mb +0.00%  | 29.442ms -11.91% | ±0.85% +20.18%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.240mb +0.00%  | 13.812μs +3.23%  | ±1.92% +52.16%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.240mb +0.00%  | 16.417μs +3.05%  | ±1.33% -9.66%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.250mb +0.00%  | 187.207ms +1.14% | ±0.87% +108.14% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 715592f into flow-php:1.x Jan 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant