Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check renderer #1063

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- path.py
- python-dateutil==2.7.3
- pip>=18.0
- tensorflow==1.15.2
- tensorflow-gpu==1.15.2
- setuptools==41.0.0
- plotly==2.4.0
- gym==0.14.0
Expand All @@ -25,4 +25,4 @@ dependencies:
- psutil
- opencv-python
- boto3==1.10.45
- redis~=2.10.6
- redis
4 changes: 2 additions & 2 deletions flow/envs/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def __init__(self,
self.sim_params = deepcopy(sim_params)
# check whether we should be rendering
self.should_render = self.sim_params.render
self.sim_params.render = False
self.sim_params.render = self.sim_params.render
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unnecessary?

time_stamp = ''.join(str(time.time()).split('.'))
if os.environ.get("TEST_FLAG", 0):
# 1.0 works with stress_test_start 10k times
Expand Down Expand Up @@ -434,7 +434,7 @@ def reset(self):
# Now that we've passed the possibly fake init steps some rl libraries
# do, we can feel free to actually render things
if self.should_render:
self.sim_params.render = True
self.sim_params.render = self.should_render
# got to restart the simulation to make it actually display anything
self.restart_simulation(self.sim_params)

Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ setproctitle
psutil
opencv-python
boto3==1.10.45
redis~=2.10.6
redis
pandas==0.24.2
plotly==2.4.0
tabulate
tensorflow==1.15.2
tensorflow-gpu==1.15.2
awscli==1.16.309
torch==1.4.0
pytz
Expand Down
22 changes: 17 additions & 5 deletions tutorials/tutorial00_flow.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
"cells": [
{
"cell_type": "markdown",
"metadata": {},
"metadata": {
"pycharm": {
"name": "#%% md\n"
}
},
"source": [
"# Tutorial 0: Flow\n",
"\n",
Expand All @@ -13,7 +17,11 @@
},
{
"cell_type": "markdown",
"metadata": {},
"metadata": {
"pycharm": {
"name": "#%% md\n"
}
},
"source": [
"## 1. High-level of Flow\n",
"\n",
Expand Down Expand Up @@ -55,7 +63,11 @@
},
{
"cell_type": "markdown",
"metadata": {},
"metadata": {
"pycharm": {
"name": "#%% md\n"
}
},
"source": [
"## 2. Codebase structure\n",
"\n",
Expand Down Expand Up @@ -96,7 +108,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
Expand All @@ -110,7 +122,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.6.8"
"version": "3.7.3"
}
},
"nbformat": 4,
Expand Down
Loading