-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rllab ec2 tutorial #40
Conversation
…it_test_backoff
…it_test_backoff
Extremely minor change to have the tests run faster. Backoff is not applied if we are in unit test mode.
moved changes from flow-devel
…ructions Linux build instructions
fixing typo (rllab->rllib)
discrete traffic light env
don't worry, commits are fine (they reflect our actual commit history). Two comments though:
|
@AboudyKreidieh - deleted the old files and added a page to the documentation. Not 100% where to put this tutorial... we might need some sort of subfolder structure for our docs, in which case we could put Setup Instructions, Tutorials, and the rllib+rllab tutorials inside those. @eugenevinitsky, thoughts? Both of you, let me know what you think of this form of the tutorial. |
Hey nish, can you add the MakeFile to this? |
Want to review it but I can't make it. |
@eugenevinitsky the Makefile should already be there - are you running |
Huh I guess it is, looking at this PR again |
First, follow the `rllab cluster setup | ||
instructions <https://rllab.readthedocs.io/en/latest/user/cluster.html>`__ | ||
with region ``us-west-1``. Modify ``rllab/config_personal.py`` to | ||
reference the most current Flow Docker image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the name of the most current Flow docker image? @kjang96 which one are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fywu85/flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/source/rllabec2.rst
Outdated
Navigate to your ``flow`` directory and modify ``Makefile.template`` per | ||
the instructions in that file. The variable ``RLLABDIR`` should be the | ||
relative path from your ``flow`` directory to ``rllab`` and should not | ||
have a backslash at the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bold "should not have a backslash at the end"
docs/source/rllabec2.rst
Outdated
- Ensure you have committed or otherwise tracked the state of your | ||
``flow`` directory, because that instance is what will be used to run | ||
your experiment. Upon visualization, the same files will need to be | ||
used—for example, changes to environment's state-space would break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"changes to your environment's state-space"
docs/source/rllabec2.rst
Outdated
your experiment. Upon visualization, the same files will need to be | ||
used—for example, changes to environment's state-space would break | ||
the ability to run a trained policy using a different state space. | ||
Check out an old commit of your ``flow`` directory and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe you need to run make prepare to use the visualization tools?"
|
||
Inside the experiment, change the ``mode`` to ``ec2`` (other options are | ||
``local`` and ``local_docker``). You should run the experiment in | ||
``local_docker`` mode briefly before running the ``ec2`` version to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a descripton of what running in local_docker tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think I should say here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Thanks for doing this Nish.
@nskh I like the idea of a tutorials substructure in the docs, can you create one and add this to it? I'm making an rllib tutorial and will include it there as well. |
@eugenevinitsky updated this but have some questions before merging - let me know when you see this. |
Pull Request Test Coverage Report for Build 1821
💛 - Coveralls |
draft tutorial is in this commit. let me know what you think.
also - an idea: these shouldn't be tutorials, but should go into our documentation. they can be easily converted to .rst files and would look nice in our docs. thoughts?
(a copy of berkeleyflow/flow#70)
(how would i remove the number of commits here?)