Additional fix for using private Google Cloud Storage Buckets #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… => 'private' is used instead of 'publicRead'
|
Looking at the history of that setting again, I think we should have a separate setting for the ACL visibility as our original use case was a two bucket setup with storage and target, and we still used public ACLs for that. I think "objectVisibility" with a default of "PublicRead" could be fine, then you can overwrite that to Private. What do you think? |
|
Yes your solution would be better. I actually started it that way when I was implementing it, but then I changed it to the "simpler" adaptation. |
|
@kitsunet I added the targetOption |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have private, non-public Cloud Storage buckets and use enableSigning = true, "predefinedAcl" => "private" will be used instead of "publicRead".