Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update cli to unstable, use new effectors #156

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

fix: Update cli to unstable, use new effectors #156

wants to merge 49 commits into from

Conversation

nahsi
Copy link
Collaborator

@nahsi nahsi commented Feb 15, 2024

No description provided.

Copy link

linear bot commented Feb 15, 2024

@nahsi nahsi changed the title chore: Update fluence-cli config to latest chore: Update fluence-cli config to latest supported by stage Feb 15, 2024
.fluence/workers.yaml Outdated Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be added to gitignore. tottally generated these files are


data Deals:
defaultWorker: ?Deal

func get() -> Deals:
<- Deals(
defaultWorker=?[Deal(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why all this stuff got removed. Probably it shouldn't have. I don't know if this needs to be deployed on stage all the time or not, maybe ask Mike


fn prepare(&self, method: &str, params: Vec<Value>) -> (RequestId, Call) {
let id = self.next_id();
let request = web3::helpers::build_request(id, method, params.clone());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [clippy] reported by reviewdog 🐶

error: redundant clone
  --> eth-rpc/eth-rpc/src/curl_transport.rs:43:70
   |
43 |         let request = web3::helpers::build_request(id, method, params.clone());
   |                                                                      ^^^^^^^^ help: remove this
   |
note: this value is dropped without further use
  --> eth-rpc/eth-rpc/src/curl_transport.rs:43:64
   |
43 |         let request = web3::helpers::build_request(id, method, params.clone());
   |                                                                ^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `-D clippy::redundant-clone` implied by `-D warnings`

@InversionSpaces InversionSpaces changed the title chore: Update fluence-cli config to unstable chore: Update fluence-cli to unstable Mar 8, 2024
@InversionSpaces InversionSpaces changed the title chore: Update fluence-cli to unstable fix: Update cli to unstable, use new effectors Mar 8, 2024
marine-rs-sdk = "=0.10.1"
log = "=0.4.20"
marine-rs-sdk = { version = "=0.14.0", features = ["logger"] }
curl-effector-imports = { git = "https://github.com/fluencelabs/effectors.git", branch = "introduce-crates" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the PR, so it should be available from master now. The branch is still not deleted, but it can be. Hope, we'll introduce a release system soon and publish it all to crates.io

Copy link

@kmd-fl kmd-fl Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw there were some additional fixes to curl, so the wasm and wasm CID are changed in the latest version. It doesn't interfere with this crate usage, so you can just leave the old wasm if you want for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants