Clarified parser behavior in documentation #1392
Conversation
pipeline/inputs/tail.md
Outdated
| @@ -88,7 +88,7 @@ pipeline: | |||
| {% endtab %} | |||
| {% endtabs %} | |||
|
|
|||
| The two options separated by a comma means multi-format: try `docker` and `cri` multiline formats. | |||
| The two options separated by a comma mean Fluent Bit will try each parser in the list in order, applying the first one that matches the log (i.e. use the first parser which has a `start_state` that matches the log). For example, it will first try `docker`, and if `docker` does not match, it will then try `cri`. | |||
There was a problem hiding this comment.
Our style would have us wrap lines around 80 characters in length, and we avoid words like i.e.
Does this suggestion still technically describe the behavior of Fluent Bit here?
Mentioning @alexakreizinger for awareness.
| The two options separated by a comma mean Fluent Bit will try each parser in the list in order, applying the first one that matches the log (i.e. use the first parser which has a `start_state` that matches the log). For example, it will first try `docker`, and if `docker` does not match, it will then try `cri`. | |
| Having the the two options separated by a comma causes Fluent Bit to attempt each | |
| parser in the list in order. Fluent But will apply the first parser that matches the | |
| log (such as the first parser that has a `start_state` that matches the log). For | |
| example, Fluent Bit will first try `docker`, and if `docker` doesn't match, it will | |
| then try `cri`. |
There was a problem hiding this comment.
Technically this is accurate and a good addition - it confuses people that this is a mutually exclusive list of options (XOR) with first parser to match "winning" and no further parsers used.
|
Can anyone review this? |
Did you update from the previous review? |
Sorry, I thought that I have already commited this :) |
|
Please resolve the DCO failure as well - that's required in order to merge. |
This change clarifies the sequential parser application process and provides a concrete example for better understanding. Signed-off-by: gvozdetsky <[email protected]> Signed-off-by: Eugene Gvozdetsky <[email protected]>
Signed-off-by: Eugene Gvozdetsky <[email protected]>
This change clarifies the sequential parser application process and provides a concrete example for better understanding.