Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change #1449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change #1449

wants to merge 2 commits into from

Commits on Aug 29, 2024

  1. Update kubernetes-events.md 

    This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate.

The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users.

Signed-off-by: Doug Whitfield <[email protected]>
    @douglasawh
    douglasawh committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    eb9e52d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Update pipeline/inputs/kubernetes-events.md 

    This language much better than my original PR. All I *had* done is take what was in there, reformat it slightly, and move it to the top.

Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Doug Whitfield <[email protected]>
    @douglasawh @lockewritesdocs
    douglasawh and lockewritesdocs committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    62bfca7 View commit details
    Browse the repository at this point in the history