pipeline: outputs: kinesis: add custom port configuration option #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new 'port' configuration option for the Kinesis output plugin. This enhancement allows users to specify a custom TCP port for connecting to the Kinesis Streams service, providing greater flexibility in network configurations. Key changes: - Added 'port' option to the configuration documentation - Updated the Kinesis output plugin to support custom port connections - Maintained default behavior (port 443) when no custom port is specified This feature is particularly useful in environments where non-standard ports are required due to network policies or when connecting through proxies that use alternative ports. The change is backwards compatible, as existing configurations without a specified port will continue to use the default port 443. Signed-off-by: Mikhail [azalio] Petrov <[email protected]>
There was a problem hiding this comment.
Thanks for your contribution @azalio! I added a suggested change.
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Mikhail Petrov <[email protected]>
Thank you for your suggestion! |
lockewritesdocs
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new 'port' configuration option for the Kinesis output plugin. This enhancement allows users to specify a custom TCP port for connecting to the Kinesis Streams service, providing greater flexibility in network configurations.
Key changes:
This feature is particularly useful in environments where non-standard ports are required due to network policies or when connecting through proxies that use alternative ports.
The change is backwards compatible, as existing configurations without a specified port will continue to use the default port 443.