-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_kinesis_streams: Add Port config option for Kinesis plugin #9171
out_kinesis_streams: Add Port config option for Kinesis plugin #9171
Conversation
@PettitWesley Can you please check this PR |
@cosmo0920 seems like @PettitWesley is inactive for a while. Is it possible if this PR can be reassigned? |
@ashie seems like no one is responding to this PR. Could you please help me get this checked with the right person :) |
Hey, he is a head of Fluentd development team but he is not active for Fluent Bit, I'm afraid. |
Could you add a documentation PR for corresponding this? |
@cosmo0920 it's already done and got approved fluent/fluent-bit-docs#1421 I didn't know he is not part of Fluent-bit :( |
@cosmo0920 any updates on this? |
@cosmo0920 ping for review |
@edsiper ping for review |
Signed-off-by: Athish Pranav D <[email protected]>
Signed-off-by: Athish Pranav D <[email protected]>
d295dab
to
8584f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding test cases and port number assertions would be good to have.
@cosmo0920 i guess we cant access the member variables here so asserting port number seems not possible. Is there any wrapper that exposes these internal struct variables? I couldnt see similar tests in other runtime tests For now i have added the port configuration too in the UT |
Signed-off-by: Athish Pranav D <[email protected]>
We can use flb_lib mechanism for testing with configs. |
Add option to configure port for Kinesis plugin
Addresses #9160
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Updated docs for kinesis plugin fluent-bit-docs#1421
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.