Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix https://github.com/fluent/fluent-bit/issues/9368 #9369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Crispy-fried-chicken
Copy link

fix #9368

@leonardo-albertovich
Copy link
Collaborator

Is this just a patch for that bit of code or was this the only part of protobuf-c.c that was modified at all?
Just to be clear, the idea is to update the entire file, not to backport changes.

@patrick-stephens
Copy link
Contributor

@Crispy-fried-chicken Fluent Bit vendors in its libraries so we do not typically patch them in place but instead take updated versions from upstream.

In this case I think the issue is cmetrics using an older protobuf-c version so we need to update that in cmetrics, then bring in the new version of cmetrics to Fluent Bit: https://github.com/fluent/cmetrics

Also please update the PR name and commits based on the contribution guidelines - the DCO check is required to merge for example: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md

@Crispy-fried-chicken
Copy link
Author

@patrick-stephens so maybe I need to open a PR in https://github.com/fluent/cmetrics?

@patrick-stephens
Copy link
Contributor

@patrick-stephens so maybe I need to open a PR in https://github.com/fluent/cmetrics?

Yes, it needs a fix there then we bring the release in here via a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Vulnerability - Action Required: Integer Overflow or Wraparound vulnerability may in your project
3 participants