feat(fluentd): add annotations to configs / dashboards #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boojapho
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
stevehipwell
requested changes
May 23, 2023
There was a problem hiding this comment.
Thanks for the PR @Boojapho. Could you separate it out into a PR per chart as each chart will have a separate approval process?
RE the actual changes I'm not sure if it's valid to group behaviour based on resource type (ConfigMap).
Signed-off-by: Michael McLeroy <[email protected]>
Boojapho
force-pushed
the
configmap-annotations
branch
from
4d23ec0
to
2de9165
Compare
Boojapho
changed the title
Signed-off-by: Michael McLeroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #357
Fluentd chart:
configs.annotations: {}. When set, the configMapConfigs and fileConfigs will have annotations applied.dashboards.annotations: {}. When set, the dashboard config will have annotations applied.