Avoid to write linked path #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fluentd usually uses predictable paths for dumping object information. However, if systemd manages fluentd, it will send a SIGCONT to fluentd when the managed service is stopped or restarted (see 'man systemd.kill'). Thus, if a malicious link(s) are in place in /tmp, the attack will eventually be triggered. Signed-off-by: Hiroshi Hatake <[email protected]>
0666 is the default permission for Kernel.open. But it shouldn't be used because we should use minimal permission. If we use default permission for dumping target path, dangling linked file is provided for target path which shouldn't be created elevated parmission having file, that is, world-writable permitted file. Signed-off-by: Hiroshi Hatake <[email protected]>
|
@frsyuki Could you kindly take a look if you have a time? We think that maintainace of this gem is important for Fluentd community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sigdump uses predictable path to write object dump.
But, in some circumstances, this implementation makes a vulnerability for dangling symlink attack.
And also,
Kernel.openshould use0644instead of0666(wolrd-writable permission).This will be also vulnerability part of dangling symlink attack.