Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 Update Fixes #212

Open
wants to merge 1 commit into
base: 1.4
Choose a base branch
from
Open

1.5 Update Fixes #212

wants to merge 1 commit into from

Conversation

Phenrei
Copy link
Contributor

@Phenrei Phenrei commented Mar 14, 2024

Updates assembles to support newest and fixes two simple issues causing build or run failures:

  1. Two missing work types in the icon assignments
  2. Negative index issue on startup when trying to replace LabelShortWithIcon in the Harmony patch. Forcing use of 0 is working, and I wrapped it in a catch statement in case this is a bug on Ludeon's part that is later resolved and the index moves back to a valid number.

Update assemblies, resolve two missing work types, fix for negative index on LabelShortWithIcon
@Phenrei Phenrei changed the base branch from 1.3 to 1.4 March 14, 2024 22:04
@Kupie
Copy link

Kupie commented Apr 23, 2024

Thanks for all these! Merging the fixes and compiling for my own personal use worked.

@stjabo
Copy link

stjabo commented Jun 16, 2024

I can't figure out which versions of these files you are editing. For example:

  1. I've downloaded the source code for v5.0.353.
  2. Within Job_Extensions.cs, //social occurs at line 178. In your commit, it appears at line 159.

What am I missing?
Thanks.

@Doomster14
Copy link

2. Within Job_Extensions.cs, //social occurs at line 178.  In your commit, it appears at line 159.

The author didn't assign a newer default branch, and you're on a default branch 1.3. On branch 1.4, it is line 159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants