Update to use ESLint without formatting rules and plugin with them. #18
Conversation
|
I have cut |
index.js
Outdated
| // foo | ||
|
|
There was a problem hiding this comment.
Must have been a wrong window kind of thing, thanks for catching it. It's gone now.
…will be ahead of the last full release version.
|
Just a note here, I noticed that the current version was "backward facing", i.e. it matches the previous full release, so dev releases of this work were showing up before the last full release in I updated this pull to use the next patch release. I can bump to the next minor release if preferred. |
There was a problem hiding this comment.
@duhrer Looks great. I did have one question related to the Grunt dependencies.
| "devDependencies": { | ||
| "grunt": "1.5.3", | ||
| "grunt-eslint": "24.0.0", | ||
| "grunt": "1.6.1", | ||
| "grunt-eslint": "24.3.0", | ||
| "grunt-jsonlint": "2.1.3" | ||
| } |
There was a problem hiding this comment.
This is not strictly related to this PR but I wonder if it might be worth removing grunt etc if it's only being used for linting this package and eslint is now a dependency? If we were to do so we could change the lint script to eslint with an appropriate glob rule to target all the JS and JSON files in this package.
There was a problem hiding this comment.
I think that's good to handle in another issue, as this small change is needed to allow any projects to work with recent versions of ESLint.
I wrote that up as #19, and left a comment there for you. Happy to work on that once we have a chance to talk about what we want.
See #17 for details.