Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-20: Updated to [email protected] (resolves #20). #21

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

the-t-in-rtf
Copy link
Collaborator

See #20 for details. Should be merged after the comparable pulls against fluid-express, fluid-handlebars, and fluid-json-schema.

@the-t-in-rtf
Copy link
Collaborator Author

Seems like they added Chromium, which our CI setup can't handle.

not ok 11 Chromium - [undefined ms] - error
    ---
        message: >
            Error: Browser exited unexpectedly
            Non-zero exit code: 1
            Stderr: 
             mkdir: cannot create directory ‘/run/user/1001’: Permission denied
            No protocol specified
            [2021:2021:0215/090623.927454:ERROR:browser_main_loop.cc(1438)] Unable to open X display.
            
            
        browser log: |
            [object Object]
            [object Object]
            [object Object]
    ...

As this is likely to bite any project that uses a similar setup, I'll take a minute to update the CI/testem config and see if I can fix the problem easily.

@the-t-in-rtf
Copy link
Collaborator Author

I commented here mistakenly instead of fluid-json-schema, which is the pull blocking this one. I'm seeing the same issue in various projects, I'll make a ticket against fluid-testem shortly, as this is going to start popping up in any project that doesn't hard code its list of browsers to launch.

…ies and nudged any other outdated dpendency versions.
@the-t-in-rtf
Copy link
Collaborator Author

FYI this project isn't affected because it uses fluid-webdriver instead.

@the-t-in-rtf
Copy link
Collaborator Author

The browser tests were taking way too long in [email protected], I suspect a temporary CI issue, as I was able to cancel and rerun without issues. Just mentioning it in case we see if more often.

@the-t-in-rtf
Copy link
Collaborator Author

Self-merging per agreement with Antranig.

@the-t-in-rtf the-t-in-rtf merged commit 9952edc into fluid-project:main Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant