GPII-3190: Initial review for wider reuse. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgithens, this pull references a branch that you can safely work with, which has been tested with modern infusion. |
|
@the-t-in-rtf Thanks Tony! Cloning your branch now to try it out! |
|
@amb26, how do you want to work the review of the new features Steve has submitted in the pull against this branch? |
|
I guess it can work through its review in place for the time being since there are a lot of comments in progress on that pull - but in time it would be good for it to become regenerated as a pull against master together with a link to its old location |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.gpii.net/browse/GPII-3190 for details.