This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
feat!: upgrade to Laravel 11, drop Livewire 2 support #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=============================================
+ Coverage 62.57% 83.77% +21.20%
+ Complexity 91 48 -43
=============================================
Files 29 22 -7
Lines 529 265 -264
=============================================
- Hits 331 222 -109
+ Misses 198 43 -155 ☔ View full report in Codecov by Sentry. |
greatislander
requested review from
chosww and
jobara
and removed request for
chosww
jobara
reviewed
Nov 13, 2024
There was a problem hiding this comment.
I notice that there are a number of files that have been removed here which are also not in TAE. Could you confirm that they aren't need here and/or in TAE.
- src/Traits/HasRequestsToJoin.php
- stubs/app/Http/Controllers/JoinController.php
- stubs/app/Http/Controllers/UserProfileInformationController.php
- stubs/app/Http/Livewire/ResourceSelect.php
- stubs/app/Http/Requests/Auth/LoginRequest.php
- stubs/app/Http/Requests/CreateInvitationRequest.php
- stubs/app/Http/Requests/CreateOrganizationRequests.php
- stubs/app/Http/Requests/CreateResourceCollectionRequest.php
- stubs/app/Http/Requests/CreateResourceRequest.php
- stubs/app/Http/Requests/DestroyResourceCollectionRequest.php
- stubs/app/Http/Requests/DestroyResourceRequest.php
- stubs/app/Http/Requests/UpdateResourceCollectionRequest.php
- stubs/app/Http/Requests/UpdateResourceRequest.php
- stubs/config/livewire.php
- stubs/resources/views/layouts/banner.blade.php
- stubs/resources/views/livewire/resource-select.blade.php
- stubs/resources/views/resource-collections/create.blade.php
- stubs/resources/views/resource-collection/edit.blade.php
- stubs/resources/views/resource-collection/show.blade.php
- stubs/resources/views/resource-collection/create.blade.php
- stubs/resources/views/resources/edit.blade.php
- stubs/resources/views/resources/index.blade.php
- stubs/resources/views/users/admin.blade.php
- stubs/resources/views/users/edit.blade.php
- stubs/tests/Feature/AccountDeletionTest.php
- stubs/tests/Feature/JoinTest.php
- stubs/tests/Feature/PasswordChangeTest.php
- stubs/tests/Feature/ResourceSelectTest.php
- stubs/tests/Feature/JoinTest.php
- stubs/tests/Feature/MembershipTest.php
- stubs/tests/Feature/TranslatableSlugTest.php
I can confirm that they aren't needed in TAE. When TAE was created these were either not needed or replaced with comparable functionality. Anything in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all functionality except for components and related methods. Note: needs README update, working on that.