Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't include package name in tag #43

Merged

Conversation

greatislander
Copy link
Contributor

@greatislander greatislander commented Jan 8, 2024

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run start and reviewing affected routes
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

Fix Release Please tagging by removing the component name from the tag name.

Steps to test

  1. Examine release PR.

Expected behaviour: Tag should be created using v1.x.

Additional information

https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#subsequent-versions

Related issues

Not applicable.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for trivet-monolingual ready!

Name Link
🔨 Latest commit 32769fc
🔍 Latest deploy log https://app.netlify.com/sites/trivet-monolingual/deploys/659c01c91ee8a60008457275
😎 Deploy Preview https://deploy-preview-43--trivet-monolingual.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@greatislander greatislander merged commit adc8ee7 into fluid-project:main Jan 8, 2024
6 of 7 checks passed
@greatislander greatislander deleted the fix/release-tagging branch January 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant