Merge branch 'issue-16'

* issue-16: fix!: Remove udpateSettings method.
fluid-project · Jun 10, 2020 · 83bce7f · 83bce7f
2 parents 86d4551 + 03296de
commit 83bce7f
Showing 1 changed file with 4 additions and 15 deletions.
diff --git a/src/js/background/chromeSettings.js b/src/js/background/chromeSettings.js
@@ -11,7 +11,7 @@
  */
 
 /* eslint-env node */
-/* global fluid, uioPlus */
+/* global fluid */
 
 "use strict";
 
@@ -36,14 +36,6 @@ fluid.defaults("uioPlus.chrome.settings", {
     model: {
         settings: "{settings}.options.defaultSettings"
     },
-    invokers: {
-        // A dedicated invoker instead of declaratively setting up the model change is required to provide a default
-        // value for the `settings` to set. This is useful for resetting the preferences.
-        updateSettings: {
-            funcName: "uioPlus.chrome.settings.updateSettings",
-            args: ["{that}",  "{arguments}.0"]
-        }
-    },
     components: {
         domSettingsApplier: {
             type: "uioPlus.chrome.domSettingsApplier",
@@ -68,8 +60,9 @@ fluid.defaults("uioPlus.chrome.settings", {
                     reset: {
                         target: "{that reset}.options.invokers.click",
                         record: {
-                            func: "{settings}.updateSettings",
-                            args: ["{settings}.options.defaultSettings"]
+                            changePath: "{settings}.model.settings",
+                            value: "{settings}.options.defaultSettings",
+                            source: "reset"
                         }
                     }
                 }
@@ -78,10 +71,6 @@ fluid.defaults("uioPlus.chrome.settings", {
     }
 });
 
-uioPlus.chrome.settings.updateSettings = function (that, settings) {
-    that.applier.change("settings", settings || that.options.defaultSettings);
-};
-
 fluid.defaults("uioPlus.chrome.settingsContextPanel", {
     gradeNames: ["uioPlus.chrome.contextMenuPanel"],
     strings: {