Fixed multi-provider listing in consumer #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreacv98 This looks good to me, thanks! |
andreacv98
force-pushed
the
quickstart-fixes
branch
from
c487644
to
a2417f7
Compare
I rebased the branch, now everything should be fine. Thanks for the feedback! |
|
Before closing the PR and merge it I have one final observation: This would help main repo mantainers to keep a clean repo history. Thanks. |
fracappa
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
With this pull request, I want to address a bug found during personal testing of the new installation script.
The bug prevented the installer to set the correct IP addresses of the other providers during the installation of the FLUIDOS Node into the clusters.
I hope, my resolution would be welcomed by you and any feedback would be greatly appreciated.
Best regards,
Andrea