[ video_player_avplay] Make startPosition support int32_t (#778)

flutter-tizen · Nov 28, 2024 · 01bb3eb · 01bb3eb
1 parent ddfa084
commit 01bb3eb
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/packages/video_player_avplay/CHANGELOG.md b/packages/video_player_avplay/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.5.6
+
+* Make startPosition support int32_t type.
+
 ## 0.5.5
 
 * Fix select audio channel failed issue.

diff --git a/packages/video_player_avplay/README.md b/packages/video_player_avplay/README.md
@@ -12,7 +12,7 @@ To use this package, add `video_player_avplay` as a dependency in your `pubspec.
 
 ```yaml
 dependencies:
-  video_player_avplay: ^0.5.5
+  video_player_avplay: ^0.5.6
 ```
 
 Then you can import `video_player_avplay` in your Dart code:

diff --git a/packages/video_player_avplay/pubspec.yaml b/packages/video_player_avplay/pubspec.yaml
@@ -2,7 +2,7 @@ name: video_player_avplay
 description: Flutter plugin for displaying inline video on Tizen TV devices.
 homepage: https://github.com/flutter-tizen/plugins
 repository: https://github.com/flutter-tizen/plugins/tree/master/packages/video_player_avplay
-version: 0.5.5
+version: 0.5.6
 
 environment:
   sdk: ">=3.1.0 <4.0.0"

diff --git a/packages/video_player_avplay/tizen/src/plus_player.cc b/packages/video_player_avplay/tizen/src/plus_player.cc
@@ -139,6 +139,14 @@ int64_t PlusPlayer::Create(const std::string &uri,
 
   int64_t start_position = flutter_common::GetValue(
       create_message.player_options(), "startPosition", (int64_t)0);
+  if (start_position == 0) {
+    // if startPosition is in the range of int32_t, it will convert as int32_t.
+    // if startPosition >= INT32_MAX, it will convert as int64_t.
+    // TODO we will implement a new function for long type, no need call two
+    // times.
+    start_position = flutter_common::GetValue(create_message.player_options(),
+                                              "startPosition", (int32_t)0);
+  }
   if (start_position > 0) {
     LOG_INFO("[PlusPlayer] Start position: %lld", start_position);
     if (!Seek(player_, start_position)) {