Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_webrtc] Update libwebrtc to m114 version #625

Merged
merged 15 commits into from
Nov 22, 2023

Conversation

wanchao-xu
Copy link
Contributor

@wanchao-xu wanchao-xu commented Oct 31, 2023

  1. Update libwebrtc with m114 version of webrtc sdk(https://github.com/webrtc-sdk/webrtc) for tizen platform.
  2. Update flutter webrtc to 0.9.46 version.
  3. Update and format flutter_webrtc_demo.
  4. Support empty candidate for 'addCandidate' api([flutter_webrtc] Crash when trying to add empty IceCandidate #623).

@Vasques1995
Copy link

Vasques1995 commented Oct 31, 2023

My understanding right now is that the empty IceCandidate is just being ignored, although this would prevent the underlying crash it would also prevent the connection between peers. The empty candidate is part of the webrtc, the libwertc being used should be able to receive and deal with it.

@wanchao-xu wanchao-xu changed the title [flutter_webrtc_tizen] Support empty candidate for 'addCandidate' api [flutter_webrtc] Update webrtc sdk to m114version Nov 3, 2023
@wanchao-xu wanchao-xu changed the title [flutter_webrtc] Update webrtc sdk to m114version [flutter_webrtc] Update webrtc sdk to m114 version Nov 3, 2023
@wanchao-xu wanchao-xu changed the title [flutter_webrtc] Update webrtc sdk to m114 version [flutter_webrtc] Update libwebrtc to m114 version Nov 3, 2023
@wanchao-xu
Copy link
Contributor Author

wanchao-xu commented Nov 3, 2023

My understanding right now is that the empty IceCandidate is just being ignored, although this would prevent the underlying crash it would also prevent the connection between peers. The empty candidate is part of the webrtc, the libwertc being used should be able to receive and deal with it.

I have updated libwebrtc with m114 version of webrtc sdk(https://github.com/webrtc-sdk/webrtc) on Tizen platform (#625).
I also use flutter_webrtc_demo to test the empty IceCandidate with debug libwebrtc. There is an error if candidate is empty

01-01 09:06:56.653+0900 I/ConsoleMessage(P10798, T10845): flutter: Received data: {"type":"candidate","data":{"to":"606143","from":"842756","candidate":{"sdpMLineIndex":0,"sdpMid":"0","candidate":""},"session_id":"842756-606143"}}
01-01 09:06:56.653+0900 I/TizenWebRTC(P10798, T10884): (webrtc_sdp.cc:424): Failed to parse: "". Reason: Expect line: candidate:<candidate-str>

webrtc sdk can't parse empty candidate.

@wanchao-xu wanchao-xu requested a review from a team November 3, 2023 09:53
xiaowei-guan and others added 4 commits November 9, 2023 13:08
…ription is invalid.

  * libwertc has add null check for invalid candidate and session description.
  * Add null check for candidate and session description in flutter_webrtc plugin.
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
There is an analyze error below related to WillPopScope.
I think it would be a good to also contain fix.
related pr : #627

2023-11-16T06:50:34.1608399Z Running command: "dart analyze --fatal-infos" in /home/runner/work/plugins/plugins/packages/flutter_webrtc
2023-11-16T06:50:34.2456104Z Analyzing flutter_webrtc...
2023-11-16T06:50:37.1069766Z 
2023-11-16T06:50:37.1118442Z    info - example/flutter_webrtc_demo/lib/src/call_sample/call_sample.dart:287:12 - 'WillPopScope' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use
2023-11-16T06:50:37.1123290Z    info - example/flutter_webrtc_demo/lib/src/call_sample/call_sample.dart:287:12 - 'WillPopScope.new' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use

@wanchao-xu wanchao-xu closed this Nov 17, 2023
@wanchao-xu wanchao-xu reopened this Nov 17, 2023
@wanchao-xu
Copy link
Contributor Author

@JSUYA , I have removed the deprecated widget 'WillPopScope'. Please refer to 7480351

@wanchao-xu
Copy link
Contributor Author

@swift-kim, please review this update of webrtc.

@xiaowei-guan xiaowei-guan merged commit d6768f5 into flutter-tizen:master Nov 22, 2023
6 checks passed
mhoeckner pushed a commit to mhoeckner/plugins that referenced this pull request Dec 6, 2023
mhoeckner pushed a commit to mhoeckner/plugins that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants