-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_webrtc] Update libwebrtc to m114 version #625
Conversation
wanchao-xu
commented
Oct 31, 2023
•
edited
Loading
edited
- Update libwebrtc with m114 version of webrtc sdk(https://github.com/webrtc-sdk/webrtc) for tizen platform.
- Update flutter webrtc to 0.9.46 version.
- Update and format flutter_webrtc_demo.
- Support empty candidate for 'addCandidate' api([flutter_webrtc] Crash when trying to add empty IceCandidate #623).
My understanding right now is that the empty IceCandidate is just being ignored, although this would prevent the underlying crash it would also prevent the connection between peers. The empty candidate is part of the webrtc, the libwertc being used should be able to receive and deal with it. |
I have updated
|
…ription is invalid. * libwertc has add null check for invalid candidate and session description. * Add null check for candidate and session description in flutter_webrtc plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
There is an analyze error below related to WillPopScope
.
I think it would be a good to also contain fix.
related pr : #627
2023-11-16T06:50:34.1608399Z Running command: "dart analyze --fatal-infos" in /home/runner/work/plugins/plugins/packages/flutter_webrtc
2023-11-16T06:50:34.2456104Z Analyzing flutter_webrtc...
2023-11-16T06:50:37.1069766Z
2023-11-16T06:50:37.1118442Z info - example/flutter_webrtc_demo/lib/src/call_sample/call_sample.dart:287:12 - 'WillPopScope' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use
2023-11-16T06:50:37.1123290Z info - example/flutter_webrtc_demo/lib/src/call_sample/call_sample.dart:287:12 - 'WillPopScope.new' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use
@swift-kim, please review this update of webrtc. |
Co-authored-by: xiaowei guan <[email protected]>
Co-authored-by: xiaowei guan <[email protected]>