Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sensor_plus] Implement set*SamplingPeriod method call #634

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[sensor_plus] Implement set*SamplingPeriod method call #634

merged 1 commit into from
Nov 30, 2023

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented Nov 28, 2023 •
edited
Loading

  • Implement set*SamplingPeriod method call.
  • Update deprecated API in integration_test.
  • Update sensors_plus to 4.0.1.
  • Update sensors_plus_platform_interface to 1.2.0.

@JSUYA JSUYA force-pushed the dev/sensor_plus/fix_test branch from 0f89dd2 to 1ef2c54 Compare November 28, 2023 05:33
@JSUYA JSUYA changed the title [sensor_plus] Update deprecated API in integration_test [sensor_plus] Implement set*SamplingPeriod method call Nov 28, 2023
@JSUYA JSUYA force-pushed the dev/sensor_plus/fix_test branch from 1ef2c54 to 97da567 Compare November 28, 2023 05:52
@JSUYA JSUYA force-pushed the dev/sensor_plus/fix_test branch from 97da567 to f629e46 Compare November 29, 2023 04:35
@JSUYA JSUYA force-pushed the dev/sensor_plus/fix_test branch from f629e46 to 06e1dc3 Compare November 29, 2023 07:38
swift-kim
swift-kim approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me. Thanks!

packages/sensors_plus/tizen/src/sensors_plus_plugin.cc Outdated Show resolved Hide resolved
@JSUYA JSUYA force-pushed the dev/sensor_plus/fix_test branch from 06e1dc3 to a36d310 Compare November 29, 2023 08:14
@JSUYA JSUYA merged commit 414390a into flutter-tizen:master Nov 30, 2023
6 checks passed
mhoeckner pushed a commit to mhoeckner/plugins that referenced this pull request Dec 6, 2023
@JSUYA @mhoeckner
[sensor_plus] Implement set*SamplingPeriod method call (flutter-tizen…
fe50b23 
…#634)
mhoeckner pushed a commit to mhoeckner/plugins that referenced this pull request Dec 7, 2023
@JSUYA @mhoeckner
[sensor_plus] Implement set*SamplingPeriod method call (flutter-tizen…
96a93f3 
…#634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swift-kim swift-kim swift-kim approved these changes

Assignees
No one assigned
Labels
p: sensors_plus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSUYA @swift-kim