apply the "CI tasks" check to all repos #3997
Open
+82
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's some failing tests that make assumptions that no other tasks are scheduled? |
|
Yes, I need to update tests for non-flaux repos that currently do not expect to see this check. |
yjbanov
force-pushed
the
ci-tasks-on-all-repos
branch
from
007f3f9
to
7808121
Compare
yjbanov
force-pushed
the
ci-tasks-on-all-repos
branch
from
7808121
to
f5e893d
Compare
jtmcdole
approved these changes
Nov 1, 2024
Comment on lines
+432
to
+435
| /// A merge group must pass all the checks in order to land on the target | ||
| /// branch. | ||
| /// | ||
| /// Compare with the usage of this lock in [triggerPresubmitTargets]. |
There was a problem hiding this comment.
nit: double slash vs tripple slash?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be safe to apply the "CI tasks" to all repos.
In repos that are not yet configured to use MQ, it will simply appear as an extra check on every PR that completes together with "ci.yaml validation", which shouldn't be disruptive.
Repos that are configured to use MQ will have this check configured as required, and this code will simply complete it as normal both in the PR and in the merge queue.