Update when deeplink appid and bundle id are collected #8801
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-hyj
reviewed
Jan 23, 2025
| @@ -32,6 +32,12 @@ enum AnalyzeFlutterProject { | |||
| /// iOS Universal Links settings are loaded. | |||
| iosUniversalLinkSettingsLoaded, | |||
|
|
|||
There was a problem hiding this comment.
can you update the comments here to differentiate them from androidAppLinksSettingsLoaded and iosUniversalLinkSettingsLoaded
There was a problem hiding this comment.
ah thanks for catching it, copy paste error
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/devtools/8801, because - The status or check suite main has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chunhtai
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update ga metrics collection for deeplink. It now only also collect the event right before the validation to reduce noise in impact tracking.
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.