Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CQ] cleanup unnecessary_ignores #8825

Merged
merged 2 commits into from
Jan 30, 2025
Merged

[CQ] cleanup unnecessary_ignores #8825

merged 2 commits into from
Jan 30, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented Jan 30, 2025 •
edited
Loading

Adds the unnecessary_ignore lint and cleans up some unneeded ignore comments.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@pq pq requested review from kenzieschmoll, bkonyi, elliette and a team as code owners January 30, 2025 00:02
@pq
Copy link
Contributor Author

pq commented Jan 30, 2025

Huh. There's something funny in the analysis of the case_study apps. I'll remove the lint enforcement for now.

@pq pq changed the title [CQ] enforce and cleanup unnecessary_ignores [CQ] cleanup unneccessary_ignores Jan 30, 2025
@pq pq changed the title [CQ] cleanup unneccessary_ignores [CQ] cleanup unnecessary_ignores Jan 30, 2025
@pq pq merged commit 1bdcf7a into flutter:master Jan 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkonyi bkonyi bkonyi approved these changes

@kenzieschmoll kenzieschmoll Awaiting requested review from kenzieschmoll kenzieschmoll is a code owner

@elliette elliette Awaiting requested review from elliette elliette is a code owner

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pq @bkonyi