[Impeller] make labeling APIs exclusively use std::string_view. #55918
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| @@ -30,10 +30,7 @@ class HostBuffer { | |||
| static std::shared_ptr<HostBuffer> Create( | |||
| const std::shared_ptr<Allocator>& allocator); | |||
|
|
|||
| // |Buffer| | |||
| virtual ~HostBuffer(); | |||
There was a problem hiding this comment.
This label was never set
jonahwilliams
added
the
autosubmit
…157118) flutter/engine@7d1abd9...31aaaaa 2024-10-17 [email protected] Manual roll Dart SDK from d916a5f69a48 to 993d3069f42e (35 revisions) (flutter/engine#55927) 2024-10-17 [email protected] [Impeller] make labeling APIs exclusively use std::string_view. (flutter/engine#55918) 2024-10-17 [email protected] Started using a specific python for yapf (flutter/engine#55905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Many of our labeling APIs accepted a std::string. When provided with a string literal (const char*), this would force the allocation of a new std::string object and a copy of the original char*. std::string_view is a view of either a std::string, or a const char* (or other), which allows an API that doesn not need to store the string to accept both without a copy. Of course, we can't store a std::string_view, as that doesn't provide memory ownership - so many of the GLES implementations will still copy the string_view into a string locally.
Also updates several of the debug labelling functions to no-op in release mode and removes some expensive interpolations that aren't super necessary.